Feat [188128]: Set up react project #36
Conversation
www/DISC_EXAMPLE-02-02.xml
Outdated
There was a problem hiding this comment.
I suggest not committing this, rather putting a link or info about where to find it
package-lock.json
Outdated
There was a problem hiding this comment.
Could it be that this one is not used, just the one in www?
| </g> | ||
| width="3.43931mm" height="17.4611mm" viewBox="-0.40625 -2.03125 0.8125 4.125"> | ||
| <defs vector-effect="non-scaling-stroke" /> | ||
| <g> |
There was a problem hiding this comment.
Jeg tror jeg likte den gamle formateringa best, men det er jo virkelig ikke viktig.
| - Add the node to the boundary class, and remove it from the internal class. | ||
| - Update rdfox, insert the following triple :nodeId a :boundary . | ||
| - Update rdfox, delete the following triple :nodeId a :insideBoundary . | ||
| - Ctrl+left click to select or deselect the internal component |
There was a problem hiding this comment.
| - Ctrl+left click to select or deselect the internal component | |
| - Shift+left click to select or deselect the internal component |
www/src/utils/Highlighting.ts
Outdated
There was a problem hiding this comment.
When a pipe is selected as bounday, the highligthing of completion package/inside is not updated. To reproduce, select the tank as internal, and two pipes as part of the boundary
www/src/App.css
Outdated
There was a problem hiding this comment.
Remove css that is not in use please
There was a problem hiding this comment.
Are these changes only formatting? If so, I would suggest to revert them in this PR and rather do a separate PR with only the formatting
There was a problem hiding this comment.
Can this file be removed?
| let resultInside = parseNodeIds(await queryTripleStore(queryInside) as string); | ||
| const resultBoundary = parseNodeIds(await queryTripleStore(queryBoundary) as string); | ||
|
|
||
| if (resultInside.length > 0 || resultBoundary.length > 0) { |
There was a problem hiding this comment.
Please remove commented out code
User Story 188128
Set up React project
A react project has been set up for the frontend using Vite.
Port functionality from vanilla JavaScript
Functionality for contact with the triplestore and highlighting has been moved over to React. This functionality is split up into different files for readability. The P&ID is displayed in a component named Diagram.
Update RunGuide.md
The steps to run the project has changed. RunGuide has been updated.
AB#188128